[Kde-pim] Review Request: Ignore call to ImapResource::retrieveItems without rid

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104634/#review12844
-----------------------------------------------------------

Ship it!


Looks good to me.

- Kevin Ottens


On April 17, 2012, 12:17 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104634/
> -----------------------------------------------------------
> 
> (Updated April 17, 2012, 12:17 a.m.)
> 
> 
> Review request for Akonadi, Kevin Ottens and Volker Krause.
> 
> 
> Description
> -------
> 
> If there are not synchronized folders in the resource, a call to ImapResource::retrieveItems( const Collection &col ) fails (and prints an "Got incomplete ancestor chain.." error message), due to the missing rid.
> The call to retrieveItems is caused by FetchHelper::triggerOnDemandFetch() in the akonadi server, during an ItemFetch operation. The actual itemfetches don't cause a call to retrieveItems as they correctly deliver the data from the database.
> I don't think we can/should avoid the call in the server.
> 
> Maybe the rid check should go to ResourceBasePrivate::slotSynchronizeCollection( const Collection &col ) instead (which is what I think gets called by triggerOnDemandFetch in the end), but according to volker resources may also completely ignore the rid, thus making the call to retrieveItems without rid valid.
> 
> 
> Diffs
> -----
> 
>   resources/imap/imapresource.cpp 441fac91b174344e22ae3bdd63af9338a0707da3 
>   resources/imap/resourcestate.cpp 9dd061d2c582cfcdbfdc55a7c515b4c391712106 
> 
> Diff: http://git.reviewboard.kde.org/r/104634/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/