[Kde-pim] Review Request: Respect NoInferiors, and disallow creating new collections accordingly.

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104658/#review12845
-----------------------------------------------------------

Ship it!


Minor nitpicks, otherwise good to go.


resources/imap/noinferiorsattribute.h
<http://git.reviewboard.kde.org/r/104658/#comment10012>

    White space error here.



resources/imap/retrievecollectionstask.cpp
<http://git.reviewboard.kde.org/r/104658/#comment10013>

    Probably want to comment that out?


- Kevin Ottens


On April 18, 2012, 2:51 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104658/
> -----------------------------------------------------------
> 
> (Updated April 18, 2012, 2:51 p.m.)
> 
> 
> Review request for Akonadi and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Currently the NoInferiors flag is ignored, resulting in errors when trying to create collections on the server. This patch adds support for it, overriding the acls as it should.
> from rfc2060: 
> It is not possible for any child levels of hierarchy to exist under this name; no child levels exist now and none can be created in the future.
> 
> 
> Diffs
> -----
> 
>   resources/imap/CMakeLists.txt a2836101fda1049bb15b2367467b724cf98c9602 
>   resources/imap/noinferiorsattribute.h PRE-CREATION 
>   resources/imap/noinferiorsattribute.cpp PRE-CREATION 
>   resources/imap/retrievecollectionmetadatatask.cpp 7f8f7e82fe59889952f0d1999a00c84a719f464d 
>   resources/imap/retrievecollectionstask.cpp 658ba803d544e60a72072eeb613b869b8e43f55d 
>   resources/imap/tests/testretrievecollectionmetadatatask.cpp 3db7ab998a650e97d9b09352862c03fe30eec142 
>   resources/imap/tests/testretrievecollectionstask.cpp 2a3ce351b087a7bf77e051dd1503362b3e9bc6d0 
> 
> Diff: http://git.reviewboard.kde.org/r/104658/diff/
> 
> 
> Testing
> -------
> 
> Added unittest, tried on cyrus-imap system.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/