[Kde-pim] Review Request: Check resourceid to decide if a resource is the owner of the entity

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104591/#review12399
-----------------------------------------------------------

Ship it!


Looks good, the extra parenthesis around the == expressions are not necessary though, but that's purely a style issue.

- Volker Krause


On April 13, 2012, 3:04 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104591/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 3:04 p.m.)
> 
> 
> Review request for Akonadi and Volker Krause.
> 
> 
> Description
> -------
> 
> Currently a any resource talking to the akonadi server is detected as owner of an item, because the actual id of the resource is not checked. This lead to the problem that I could not modify an item in the cache from the kolabproxy, because it has not yet been synchrnoized by the imap resource (marked dirty). This patch checks now if the resource is really the owner of the entity or only acting as normal client.
> 
> 
> Diffs
> -----
> 
>   server/src/akonadiconnection.cpp 256692d9d3e032f01ae464d7591ebc2972b64b62 
> 
> Diff: http://git.reviewboard.kde.org/r/104591/diff/
> 
> 
> Testing
> -------
> 
> Unittests still work, the kolabproxy can modify the item in the cache as expected.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/