[Kde-pim] Review Request: Do not add an organizer to appointments without attendees

[Stephan Diestelhorst]

Am Montag 02 April 2012, 16:39:56 schrieb Andre Heinecke:
> > On March 22, 2012, 4:31 p.m., Andre Heinecke wrote:
> > > incidenceeditor-ng/incidencedefaults.cpp, line 390
> > > <http://git.reviewboard.kde.org/r/104368/diff/1/?file=54278#file54278line390>
> > >
> > >     With that ifdef enabled the Organizer would be added as an attendee.
> > >     So you no longer would have an organizer for an incidence without attendees.
> > >     
> > >     Please move that ifdefed part out of the !mAttendees.empty() part so that this behavior would stay unchanged.
> > 
> > Stephan Diestelhorst wrote:
> >     I was not sure what the logic is, here.   You always want to add the organizer as an attendee, even if there are no attendees present?  If so, then it should also get added as an organizer, since there is an attendant?
> >     
> >     What is that ENTERPRISE_BUILD used for?
> 
> Thanks for updating your patch, and yes always adding the organizer as an attendee is wanted.
> 
> ENTERPRISE_BUILD comes from merging Enterprise developments of Kdepim that were developed for a customer into upstream sources. Since sometimes the whishes of a customer (like in this case) differ from what makes sense or from what the rest of the community wants. So there is a build Option to change some behavior in case of disagreements. 
> 
> From my point of view there are no more concerns with your Patch now, thanks.

Ah.  Thanks for clarifying and reviewing!

Stephan
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/