[Kde-pim] Review Request: Fix double margin in KHoliday::RegionSelector

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102971/#review7736
-----------------------------------------------------------


This review has been submitted with commit fe0d6157fbec6e5207bd4d67b8e0d2d9faae69a6 by David Edmundson to branch master.

- Commit Hook


On Oct. 26, 2011, 12:24 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102971/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2011, 12:24 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Widgets should not have margins on themselves, otherwise they get a double margin when used in something with a layout.
> 
> Old code causes the difference in red lines here: 
> http://static.davidedmundson.co.uk/padding_blog/select_calendar_lines.png
> 
> 
> Diffs
> -----
> 
>   kholidays/holidayregionselector.ui 7f8735d 
> 
> Diff: http://git.reviewboard.kde.org/r/102971/diff/diff
> 
> 
> Testing
> -------
> 
> Tested everything now lined up. If you know of any other uses of RegionSelector I will test them too, but as long as they are in a layout they should be improved also.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/