[Kde-pim] Review Request: Fix double margin in KHoliday::RegionSelector

David Edmundson kde at davidedmundson.co.uk
Wed Oct 26 01:24:20 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102971/
-----------------------------------------------------------

Review request for KDEPIM-Libraries.


Description
-------

Widgets should not have margins on themselves, otherwise they get a double margin when used in something with a layout.

Old code causes the difference in red lines here: 
http://static.davidedmundson.co.uk/padding_blog/select_calendar_lines.png


Diffs
-----

  kholidays/holidayregionselector.ui 7f8735d 

Diff: http://git.reviewboard.kde.org/r/102971/diff/diff


Testing
-------

Tested everything now lined up. If you know of any other uses of RegionSelector I will test them too, but as long as they are in a layout they should be improved also.


Thanks,

David Edmundson

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list