[Kde-pim] Review Request: Fix double margin in KHoliday::RegionSelector

[John Layt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102971/#review7694
-----------------------------------------------------------

Ship it!


Thanks, I was never happy with the plasma widget layout and cringed when I saw you blog about it :-)  Proves I'm a libs coder not a gui coder...

I don't know anyone else that uses it yet.

Cheers!

John.

- John Layt


On Oct. 26, 2011, 12:24 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102971/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2011, 12:24 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Widgets should not have margins on themselves, otherwise they get a double margin when used in something with a layout.
> 
> Old code causes the difference in red lines here: 
> http://static.davidedmundson.co.uk/padding_blog/select_calendar_lines.png
> 
> 
> Diffs
> -----
> 
>   kholidays/holidayregionselector.ui 7f8735d 
> 
> Diff: http://git.reviewboard.kde.org/r/102971/diff/diff
> 
> 
> Testing
> -------
> 
> Tested everything now lined up. If you know of any other uses of RegionSelector I will test them too, but as long as they are in a layout they should be improved also.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/