[Kde-pim] Review Request: Patch for GetQuotaRoot job in kimap

[Lukáš Krejčí]

> On Nov. 16, 2011, 8:32 a.m., Andras Mantia wrote:
> > Can you please send me a dump of the communication with the problem? I will create a test from that.
> 
> Lukáš Krejčí wrote:
>     I sent you an email w/ the data.

BTW. the patch from laloch at atlas.cz attached to the BZ (https://bugs.kde.org/attachment.cgi?id=56569) is *exactly* what is being discussed here even with the removal of the "rootIndex" and the use of "unite()".

I think that both laloch's and my patch actually make the impl conform to the spec. According to my understanding, the spec describes following server<->client exchanges:

C: GETQUOTAROOT mailbox
S: QUOTAROOT mailbox "a" "b" "c" //in here the a, b and c are "implementation defined quota roots" as the spec describes them. Note that centrum.cz for example has a single quotaroot called "".
S: QUOTA a (STORAGE 1 2 )
S: QUOTA a (MESSAGE 1 2 )
S: QUOTA b (STORAGE 1 2 )
S: QUOTA b (MESSAGE 1 2 )
S: QUOTA c (STORAGE 1 2 )
S: QUOTA c (MESSAGE 1 2 )


The current implementation handles incorrectly (and crashes on) this kind of response (which a) conforms to the spec as I understand it and b) is what centrum.cz and atlas.cz (at least) seem to return) because:

1) It assumes that the QUOTAROOT response has 4 parts (it can have 3 parts legally)
2) It assumes that there is at most 1 quota response per quota root (again, the spec specifically lists STORAGE and MESSAGE as possible "resources" that can be limited by a quota)


- Lukáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103150/#review8223
-----------------------------------------------------------


On Nov. 16, 2011, 7:22 a.m., Lukáš Krejčí wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103150/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2011, 7:22 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Andras Mantia.
> 
> 
> Description
> -------
> 
> This is a proposed patch for the get quota root bug.
> 
> 
> This addresses bug 264622.
>     http://bugs.kde.org/show_bug.cgi?id=264622
> 
> 
> Diffs
> -----
> 
>   kimap/getquotarootjob.cpp f82bf40 
> 
> Diff: http://git.reviewboard.kde.org/r/103150/diff/diff
> 
> 
> Testing
> -------
> 
> Manual - created the imap resource and encountered no crash on startup. KMail2 was able to read mails afterwards.
> I didn't have time to come up with a unit test nor will I have much time to do it in the future but I think I can provide a dump of communication between kimap and my IMAP server which the unit test could be based on if someone is interested.
> 
> 
> Thanks,
> 
> Lukáš Krejčí
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/