[Kde-pim] Review Request: Patch for GetQuotaRoot job in kimap

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103150/#review8311
-----------------------------------------------------------


This review has been submitted with commit d73681c70eceb0d8f0661e642fdcc9c22e1fcf2a by Andras Mantia to branch KDE/4.7.

- Commit Hook


On Nov. 16, 2011, 7:22 a.m., Lukáš Krejčí wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103150/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2011, 7:22 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Andras Mantia.
> 
> 
> Description
> -------
> 
> This is a proposed patch for the get quota root bug.
> 
> 
> This addresses bug 264622.
>     http://bugs.kde.org/show_bug.cgi?id=264622
> 
> 
> Diffs
> -----
> 
>   kimap/getquotarootjob.cpp f82bf40 
> 
> Diff: http://git.reviewboard.kde.org/r/103150/diff/diff
> 
> 
> Testing
> -------
> 
> Manual - created the imap resource and encountered no crash on startup. KMail2 was able to read mails afterwards.
> I didn't have time to come up with a unit test nor will I have much time to do it in the future but I think I can provide a dump of communication between kimap and my IMAP server which the unit test could be based on if someone is interested.
> 
> 
> Thanks,
> 
> Lukáš Krejčí
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/