[Kde-pim] Review Request: Patch for GetQuotaRoot job in kimap

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103150/#review8221
-----------------------------------------------------------



kimap/getquotarootjob.cpp
<http://git.reviewboard.kde.org/r/103150/#comment7028>

    since d->rootIndex is not a local variable, have you checked that other code is not depending on it being set here?



kimap/getquotarootjob.cpp
<http://git.reviewboard.kde.org/r/103150/#comment7029>

    that can probably be collapsed into one line
    d->quotas[ rootName ].unite(quota)
    
    QMap::operator[] returns an empty element if the key is not contained, unite on an empty element might do the right thing


- Kevin Krammer


On Nov. 16, 2011, 7:22 a.m., Lukáš Krejčí wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103150/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2011, 7:22 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Andras Mantia.
> 
> 
> Description
> -------
> 
> This is a proposed patch for the get quota root bug.
> 
> 
> This addresses bug 264622.
>     http://bugs.kde.org/show_bug.cgi?id=264622
> 
> 
> Diffs
> -----
> 
>   kimap/getquotarootjob.cpp f82bf40 
> 
> Diff: http://git.reviewboard.kde.org/r/103150/diff/diff
> 
> 
> Testing
> -------
> 
> Manual - created the imap resource and encountered no crash on startup. KMail2 was able to read mails afterwards.
> I didn't have time to come up with a unit test nor will I have much time to do it in the future but I think I can provide a dump of communication between kimap and my IMAP server which the unit test could be based on if someone is interested.
> 
> 
> Thanks,
> 
> Lukáš Krejčí
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/