[Kde-pim] Re: Review Request: Make Akonadi item's id and url available to script actions.

[Sergio Luis Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100645/#review1527
-----------------------------------------------------------



mailcommon/filteraction.cpp
<http://git.reviewboard.kde.org/r/100645/#comment1292>

    Break this line up in two by storing the result of aMsg->headerByType(..cap(1).toLatin1() ) so you don't have to call it twice. Also makes it readable, it's quite big.
    
    Make replacement const.
    
    s/""/QLatin1String( "" )
    
    
    2cents++


- Sergio Luis


On Feb. 13, 2011, 1:08 p.m., Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100645/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2011, 1:08 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> With this patch, the Akonadi item's id and url are available for the script/program execution and pipe-through filter actions. This allows scripts that process the message to store a reference to the item/message which can then later be used to find it again. 
> 
> 
> Diffs
> -----
> 
>   doc/kmail/using-kmail.docbook 879669e 
>   mailcommon/filteraction.h ca4c5ae 
>   mailcommon/filteraction.cpp d86a12a 
> 
> Diff: http://git.reviewboard.kde.org/r/100645/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/