[Kde-pim] Re: Review Request: Make Akonadi item's id and url available to script actions.

[Ingo Klöcker]

> On Feb. 20, 2011, 1:48 p.m., Sergio Luis Martins wrote:
> > mailcommon/filteraction.cpp, line 554
> > <http://git.reviewboard.kde.org/r/100645/diff/1/?file=9078#file9078line554>
> >
> >     Break this line up in two by storing the result of aMsg->headerByType(..cap(1).toLatin1() ) so you don't have to call it twice. Also makes it readable, it's quite big.
> >     
> >     Make replacement const.
> >     
> >     s/""/QLatin1String( "" )
> >     
> >     
> >     2cents++

Till didn't touch this line. He could beautify it, but IMHO not as part of this change.

And, FWIW,
  s/""/QString()/
And KShell::quoteArg() should be moved inside the ?: operator because it doesn't really make sense to call it on "" (or QString()).
Anyway, that's for another patch.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100645/#review1527
-----------------------------------------------------------


On Feb. 13, 2011, 1:08 p.m., Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100645/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2011, 1:08 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> With this patch, the Akonadi item's id and url are available for the script/program execution and pipe-through filter actions. This allows scripts that process the message to store a reference to the item/message which can then later be used to find it again. 
> 
> 
> Diffs
> -----
> 
>   doc/kmail/using-kmail.docbook 879669e 
>   mailcommon/filteraction.h ca4c5ae 
>   mailcommon/filteraction.cpp d86a12a 
> 
> Diff: http://git.reviewboard.kde.org/r/100645/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/