[Kde-pim] Review Request: Emit signals in the monitor also for subcollections of a monitored collection

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100585/
-----------------------------------------------------------

Review request for KDEPIM, Volker Krause and Stephen Kelly.


Summary
-------

Patch from steve (posted in review 0001-Prefetch-collections-if-needed-before-filtering.patch) with three modifications from myself:

-handle case when a resource and a collection is monitored in acceptNotifications()
-always emit a move signal, if a monitored collection is moved in appendAndCompress()
-dispatchNotifications in prefetchDataAvailable()

This was a counter proposal to what I proposed in http://git.reviewboard.kde.org/r/100534/ originally.
Instead of maintaining a container of all monitored collections, it simply prefetches the collections before filtering, 
which results in much cleaner code.


Diffs
-----

  akonadi/monitor.h 33b8fa57409a4e5029cf1a7c46189a0ff24d9391 
  akonadi/monitor.cpp d433ab65c31eba215cbb3d6dea276a2cc7a14103 
  akonadi/monitor_p.h cc255c708c8daa0d606a83ea78424e9eba616b17 
  akonadi/monitor_p.cpp 745d0ec6e51342100dcfefb3d5b4e9f4578ccb87 

Diff: http://git.reviewboard.kde.org/r/100585/diff


Testing
-------

manual testing


Thanks,

Christian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/