[Kde-pim] Re: Review Request: Splitting of move to added/removed

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100534/
-----------------------------------------------------------

(Updated Feb. 6, 2011, 3:39 p.m.)


Review request for KDEPIM-Libraries, Tobias Koenig, Volker Krause, and Stephen Kelly.


Changes
-------

Patch from steve, after removing the hack. 

Still needs the patch from http://git.reviewboard.kde.org/r/100524/ to work.

This is now really only about splitting the move signal into added / removed, not the proper implementation of monitoring collections.


Summary (updated)
-------

-Splitting of the move signal in added/removed signals.

Needs the patch from http://git.reviewboard.kde.org/r/100524/ to work.


Diffs (updated)
-----

  akonadi/monitor_p.h cc255c7 
  akonadi/monitor_p.cpp 745d0ec 
  akonadi/session_p.h 8f2e468 

Diff: http://git.reviewboard.kde.org/r/100534/diff


Testing
-------

only manual testing, couldn't get the unittests to work so far.


Thanks,

Christian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/