[Kde-pim] Re: Review Request: Simpler version of column resizing code for Akregator

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100574/
-----------------------------------------------------------

(Updated Feb. 7, 2011, 10:47 p.m.)


Review request for KDEPIM and Frank Osterfeld.


Changes
-------

I said I would not spend more time on this but then I got an even crazier idea:
- Hide the header of the article list
- Set the title column in stretch mode
- Move the column selection menu to the article list view context menu

Advantages of this version:
- Since title column is in stretch mode it always uses as much space as possible, without any hack. One can see more by either enlarging the window, adjusting the feed-list|article-list splitter or hiding some columns.
- Since the header is hidden, it feels less "jumpy" when Author column size adjust after changing to another feed.
- Hiding the header avoids the feeling that one can't resize the title column. The column content is explicit enough that it does not need a label IMO.
- Hiding the header also avoids accidentally clicking on the "Title" header when one tries to select the first item, resulting in a change in sort order instead (this was reported by a few people when I blogged about Akregator article view)
- Finally, hiding the header makes it possible to see one more article.

Drawbacks:
- Impossible to reorder columns
- Impossible to change sort order (that could be added to the popup menu, but it does not feel necessary to me)

What do you think?


Summary
-------

My previous implementation of column resizing for the article view was too smart for its own good:
- It prevented the user from enlarging the title column if it would have made the total column width greater than the viewport width
- It did not compute the width of the date column correctly

This new version is simpler: it just resize all columns but the title one to fit their content. The title column gets the remaining width.


This addresses bug 261957.
    http://bugs.kde.org/show_bug.cgi?id=261957


Diffs (updated)
-----

  akregator/src/actionmanager.h ec9296d 
  akregator/src/actionmanagerimpl.h f794351 
  akregator/src/actionmanagerimpl.cpp 2a8fc98 
  akregator/src/akregator_part.rc 4756b7d 
  akregator/src/articlelistview.h 4576a23 
  akregator/src/articlelistview.cpp bf2219d 

Diff: http://git.reviewboard.kde.org/r/100574/diff


Testing
-------

Tested both feed and group mode. Columns get reasonable widths and can be resized if need be (sometimes necessary for title column) 


Thanks,

Aurélien

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/