[Kde-pim] Re: Review Request: Simpler version of column resizing code for Akregator

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100574/#review1265
-----------------------------------------------------------


This patch introduces more issues that it solves. See the comments and screenshots in the bug report.
- Usability issue, the columns sizes are not remembered anymore. Auto-resizing columns is a *very bad* idea.
- When a feed has a long description or author, the title is unreadable,
- When there is no vertical scrollbar, there's an empty area next to the date column


- Christophe


On Feb. 5, 2011, 9:16 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100574/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2011, 9:16 a.m.)
> 
> 
> Review request for KDEPIM and Frank Osterfeld.
> 
> 
> Summary
> -------
> 
> My previous implementation of column resizing for the article view was too smart for its own good:
> - It prevented the user from enlarging the title column if it would have made the total column width greater than the viewport width
> - It did not compute the width of the date column correctly
> 
> This new version is simpler: it just resize all columns but the title one to fit their content. The title column gets the remaining width.
> 
> 
> This addresses bug 261957.
>     http://bugs.kde.org/show_bug.cgi?id=261957
> 
> 
> Diffs
> -----
> 
>   akregator/src/articlelistview.h 4576a23 
>   akregator/src/articlelistview.cpp bf2219d 
> 
> Diff: http://git.reviewboard.kde.org/r/100574/diff
> 
> 
> Testing
> -------
> 
> Tested both feed and group mode. Columns get reasonable widths and can be resized if need be (sometimes necessary for title column) 
> 
> 
> Thanks,
> 
> Aurélien
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/