[Kde-pim] Re: Review Request: kmail: fix 251009 bug. Send mail doesn't stored in the default send-mail folder if the custom one doesn't exist

[Antonis Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100269/
-----------------------------------------------------------

(Updated Feb. 15, 2011, 5:52 p.m.)


Review request for KDEPIM.


Changes
-------

Hello

I have found out what it cause the bug. In the kdepim/messagecomposer/composerbaseview.cpp the m_fccCombo object is using the currentcollection() method, which it returns a random collection, when the collection which is supposed to return, doesn't exist... So i create a patch which solves this issue. With my patch, if the custom sent-mail collection doesn't exist, then the mail is saved in the default sent-mail collection. If the custom sent-mail collection exists, then the mail is saved there. Messagecomposer and kmail compile without any issue...


Summary
-------

Hello

If you tried to send an email but the custom send-mail folder (settings->configure kmail->identities->modify->advanced) doesn't exist then the kmail doesn't store the send-mail into the default... So with this patch the send-mail is saved in the custom folder (if it exists) otherwise it is saved in the default one...


This addresses bug 251009.
    http://bugs.kde.org/show_bug.cgi?id=251009


Diffs (updated)
-----

  messagecomposer/composerviewbase.h d2d835a 
  messagecomposer/composerviewbase.cpp 45d0fec 

Diff: http://git.reviewboard.kde.org/r/100269/diff


Testing
-------

The kmail compiles fine and kmail works without any issue


Thanks,

Antonis

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/