[Kde-pim] Re: Review Request: kmail: fix 251009 bug. Send mail doesn't stored in the default send-mail folder if the custom one doesn't exist

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100269/#review1645
-----------------------------------------------------------


Thanks for the patch again.
There are still some holes in it: If the user deletes the folder while the composer is open, the bug is still triggered. Also, when the user queues the message in the outbox and sends it later, there is still a window of opportunity for the folder to get deleted.

So while the patch works, the changes should really be in the maildispatcher agent, as there is no possible race condition for the folder to get deleted in the meantime.

- Thomas


On Feb. 15, 2011, 5:52 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100269/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2011, 5:52 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> If you tried to send an email but the custom send-mail folder (settings->configure kmail->identities->modify->advanced) doesn't exist then the kmail doesn't store the send-mail into the default... So with this patch the send-mail is saved in the custom folder (if it exists) otherwise it is saved in the default one...
> 
> 
> This addresses bug 251009.
>     http://bugs.kde.org/show_bug.cgi?id=251009
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composerviewbase.h d2d835a 
>   messagecomposer/composerviewbase.cpp 45d0fec 
> 
> Diff: http://git.reviewboard.kde.org/r/100269/diff
> 
> 
> Testing
> -------
> 
> The kmail compiles fine and kmail works without any issue
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/