[Kde-pim] Review Request: Fix ETM for monitoring multiple collections

Christian Mollekopf chrigi_1 at fastmail.fm
Sat Apr 23 15:21:42 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101209/
-----------------------------------------------------------

Review request for KDEPIM and Stephen Kelly.


Summary
-------

With this patch, the ETM properly supports monitoring multiple collections.
While currently Collection::root() will be watched, as soon as multiple collections are watched, with this patch only the needed ancestor collections will be included (up to Collection::root(), without any items/collections in it).

I added the insertAndFetchCollection function, which checks for necessary parents and fetches them if needed.


Diffs
-----

  akonadi/entitytreemodel.h 881593102feef69a73fefc6c26822efdf2a97966 
  akonadi/entitytreemodel_p.h b1f9c1e47496e08a269b031f40aab4d5defc8529 
  akonadi/entitytreemodel_p.cpp e367cd79122054a3a195a76ec51de24060daa69b 

Diff: http://git.reviewboard.kde.org/r/101209/diff


Testing
-------

works for me


Thanks,

Christian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list