[Kde-pim] Re: Review Request: Always fetch root items, except for two cases

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101199/#review2848
-----------------------------------------------------------

Ship it!


Looks good.

- Stephen


On April 23, 2011, 12:16 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101199/
> -----------------------------------------------------------
> 
> (Updated April 23, 2011, 12:16 p.m.)
> 
> 
> Review request for KDEPIM and Stephen Kelly.
> 
> 
> Summary
> -------
> 
> Fetch root items always, except for noItemPopulation and LazyPopulation with shown root.
> 
> This is needed for explicitly monitored collections (otherwise the root items are not fetched).
> It also fixes lazypopulation when the root is not shown.
> 
> 
> Diffs
> -----
> 
>   akonadi/entitytreemodel_p.cpp 8e00bca032b1481b1ffe62bd7df54a85f932d46b 
> 
> Diff: http://git.reviewboard.kde.org/r/101199/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/