[Kde-pim] Re: Review Request: Port InicidenceChanger from Groupware to InvitationHandler

[Bertjan Broeksema]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5624/
-----------------------------------------------------------

(Updated 2010-10-15 13:42:50.162599)


Review request for KDE PIM and Sergio Martins.


Changes
-------

Sergio, tried to incorparate the fixes we discussed on irc, also fixed a logic error in sendGroupwareMessage. Please re-review carefully. I'm not very happy with the current state though, but don't see a quick fix to make this really better. Invitation handling will need quite some work still to make it really nice (porting away from Groupware is imo a first step in the right direction).


Summary
-------

For the mobile apps the invitation handling logic was extracted into InvitationHandler and Groupware is not used. Now we're having code that makes use of the IncidenceChanger (i.e. CalendarUtils) so we need to get rid of Groupware in IncidenceChanger as well.

If this looks ok, the code can be cleaned up a bit more (e.g. removing unneeded function params).


Diffs (updated)
-----

  /trunk/KDE/kdepim/calendarsupport/incidencechanger.h 1186060 
  /trunk/KDE/kdepim/calendarsupport/incidencechanger.cpp 1186060 
  /trunk/KDE/kdepim/calendarsupport/incidencechanger_p.h 1186060 

Diff: http://svn.reviewboard.kde.org/r/5624/diff


Testing
-------


Thanks,

Bertjan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/