[Kde-pim] Re: Review Request: Port InicidenceChanger from Groupware to InvitationHandler

[Sergio Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5624/#review8206
-----------------------------------------------------------

Ship it!


Looks ok.

Anyway, next to refactor/clean in my list is IncidenceChanger, i'll add some unit-tests that will catch if something is wrong.


/trunk/KDE/kdepim/calendarsupport/incidencechanger.cpp
<http://svn.reviewboard.kde.org/r/5624/#comment8476>

    move to IncidenceHandler?


- Sergio


On 2010-10-15 13:42:50, Bertjan Broeksema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5624/
> -----------------------------------------------------------
> 
> (Updated 2010-10-15 13:42:50)
> 
> 
> Review request for KDE PIM and Sergio Martins.
> 
> 
> Summary
> -------
> 
> For the mobile apps the invitation handling logic was extracted into InvitationHandler and Groupware is not used. Now we're having code that makes use of the IncidenceChanger (i.e. CalendarUtils) so we need to get rid of Groupware in IncidenceChanger as well.
> 
> If this looks ok, the code can be cleaned up a bit more (e.g. removing unneeded function params).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/calendarsupport/incidencechanger.h 1186060 
>   /trunk/KDE/kdepim/calendarsupport/incidencechanger.cpp 1186060 
>   /trunk/KDE/kdepim/calendarsupport/incidencechanger_p.h 1186060 
> 
> Diff: http://svn.reviewboard.kde.org/r/5624/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bertjan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/