[Kde-pim] Review Request: kdepim/kjots krazy fixes, categories: crashy, spelling and explicit

[Lasse Liehu]

> On 2010-04-10 10:32:17, Stephen Kelly wrote:
> > Committed. Thanks for the patch.
> > 
> > Sorry it took so long. Maybe you should get an svn account of your own: http://techbase.kde.org/Contribute/Get_a_SVN_Account
> > 
> > All the best,
> > 
> > Steve

Actually, I now have and could have committed it myself, but I kind of wanted to get this approved before committing or so :)

And no problem really.

Lasse


- Lasse


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3400/#review4946
-----------------------------------------------------------


On 2010-04-10 10:13:52, Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3400/
> -----------------------------------------------------------
> 
> (Updated 2010-04-10 10:13:52)
> 
> 
> Review request for KDE PIM and Stephen Kelly.
> 
> 
> Summary
> -------
> 
> Krazy fixes for kdepim/kjots. Categories crashy, spelling and explicit.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotscomponent.cpp 1107766 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotsedit.cpp 1107766 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotsentry.cpp 1107766 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotsmodel.h 1107766 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotstreeview.h 1107766 
> 
> Diff: http://reviewboard.kde.org/r/3400/diff
> 
> 
> Testing
> -------
> 
> It compiles. Also tested that using KJotsLinkDialog still works in KJotsEdit::onLinkify(), and doesn't crash (even when calling kquitapp kjots when the dialog is open). I couldn't test the modifications in onPrint() slot (in kjotscomponent.cpp), though.
> 
> 
> Thanks,
> 
> Lasse
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/