[Kde-pim] Review Request: Make Akonadi::Job::exec() more scary

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3534/#review4944
-----------------------------------------------------------


Kevin proposed to add Akonadi::executeJob( Akonadi::Job *job, Qt::EventProcessingFlags ), and to add @deprecated to exec().
executeJob() should of course also have sufficient warnings in the API docs to prevent accidental usage.

- Thomas


On 2010-04-09 19:29:38, Thomas McGuire wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3534/
> -----------------------------------------------------------
> 
> (Updated 2010-04-09 19:29:38)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> exec() causes bugs, which are sometimes hard to find. I just wasted another half an hour trying to find a bug, which turned out to be the fault of exec().
> 
> This patch will:
> - deprecate exec()
> - print a warning at runtime
> 
> That should make it much easier to identify problem spots.
> 
> 
> This addresses bugs bugs, of and tons.
>     https://bugs.kde.org/show_bug.cgi?id=bugs
>     https://bugs.kde.org/show_bug.cgi?id=of
>     https://bugs.kde.org/show_bug.cgi?id=tons
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/akonadi/akonadi_export.h 1112990 
>   trunk/KDE/kdepimlibs/akonadi/job.h 1112990 
>   trunk/KDE/kdepimlibs/akonadi/job.cpp 1112990 
> 
> Diff: http://reviewboard.kde.org/r/3534/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/