[Kde-pim] Review Request: kdepim/kjots krazy fixes, categories: crashy, spelling and explicit

[Lasse Liehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3400/
-----------------------------------------------------------

(Updated 2010-04-10 10:13:52.623179)


Review request for KDE PIM and Stephen Kelly.


Changes
-------

Added steveire to people.


Summary
-------

Krazy fixes for kdepim/kjots. Categories crashy, spelling and explicit.


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotscomponent.cpp 1107766 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotsedit.cpp 1107766 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotsentry.cpp 1107766 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotsmodel.h 1107766 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotstreeview.h 1107766 

Diff: http://reviewboard.kde.org/r/3400/diff


Testing
-------

It compiles. Also tested that using KJotsLinkDialog still works in KJotsEdit::onLinkify(), and doesn't crash (even when calling kquitapp kjots when the dialog is open). I couldn't test the modifications in onPrint() slot (in kjotscomponent.cpp), though.


Thanks,

Lasse

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/