[Kde-pim] Review Request: kmail does not honour umask on saving emails

joerg.steffens at dass-it.de joerg.steffens at dass-it.de
Wed Apr 14 11:50:26 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3601/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

When saving an email to disk (right-click on email, save-as), kmail will store
it with permissions 600 (read/write only for user, not group or others)
I expected kmail to honour the umask instead.
This has been already considered as a bug for attachment, see https://bugs.kde.org/show_bug.cgi?id=79685
I expect the same behaviour for emails.

This patch has been originally summited at https://bugs.kde.org/show_bug.cgi?id=232001


This addresses bugs 79685 and 232001.
    https://bugs.kde.org/show_bug.cgi?id=79685
    https://bugs.kde.org/show_bug.cgi?id=232001


Diffs
-----

  /trunk/KDE/kdepim/kmail/kmcommands.cpp 1114729 
  /trunk/KDE/kdepim/kmail/util.h 1114729 
  /trunk/KDE/kdepim/kmail/util.cpp 1114729 

Diff: http://reviewboard.kde.org/r/3601/diff


Testing
-------

I've tested this patch against openSUSE 11.2 and KDE 4.3.5
and modified it to apply againt SVN trunk


Thanks,

steffens

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list