[Kde-pim] Review Request: kmail does not honour umask on saving emails

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3601/#review5048
-----------------------------------------------------------


Except for a few minor issues the patch looks good.


/trunk/KDE/kdepim/kmail/kmcommands.cpp
<http://reviewboard.kde.org/r/3601/#comment4532>

    const int permissions ...



/trunk/KDE/kdepim/kmail/kmcommands.cpp
<http://reviewboard.kde.org/r/3601/#comment4535>

    Hmm, shouldn't this be
    if ( permissions > -1 )
    ?
    
    Sure, the permissions 000 do not make that much sense, but default permissions are signaled by a -1 and not by a 0.



/trunk/KDE/kdepim/kmail/kmcommands.cpp
<http://reviewboard.kde.org/r/3601/#comment4533>

    remove trailing whitespace



/trunk/KDE/kdepim/kmail/util.cpp
<http://reviewboard.kde.org/r/3601/#comment4534>

    Writing this in the form
    if ( ... ) {
      return S_IRUSR|S_IWUSR;
    } else {
      return -1;
    }
    would be a bit easier to understand and get rid of the superfluous temporary variable 'permission'.


- Ingo


On 2010-04-14 10:50:25, steffens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3601/
> -----------------------------------------------------------
> 
> (Updated 2010-04-14 10:50:25)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> When saving an email to disk (right-click on email, save-as), kmail will store
> it with permissions 600 (read/write only for user, not group or others)
> I expected kmail to honour the umask instead.
> This has been already considered as a bug for attachment, see https://bugs.kde.org/show_bug.cgi?id=79685
> I expect the same behaviour for emails.
> 
> This patch has been originally summited at https://bugs.kde.org/show_bug.cgi?id=232001
> 
> 
> This addresses bugs 79685 and 232001.
>     https://bugs.kde.org/show_bug.cgi?id=79685
>     https://bugs.kde.org/show_bug.cgi?id=232001
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmcommands.cpp 1114729 
>   /trunk/KDE/kdepim/kmail/util.h 1114729 
>   /trunk/KDE/kdepim/kmail/util.cpp 1114729 
> 
> Diff: http://reviewboard.kde.org/r/3601/diff
> 
> 
> Testing
> -------
> 
> I've tested this patch against openSUSE 11.2 and KDE 4.3.5
> and modified it to apply againt SVN trunk
> 
> 
> Thanks,
> 
> steffens
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/