[Kde-pim] Review Request: Add "(Default)" to the default identity in IdentityCombo

[Tom Albers]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1934/#review2789
-----------------------------------------------------------


I object to this patch. In the settings it makes sense to indicate which identity will be used by default. As in the composer the composer the combo can be hidden and the user would need to know which identity will be used by default.

In the combo it makes no sense to indicate "(Default)". The combo *has* a default value, indicating the default value with "(Default)" makes no sense at all. 

I removed it earlier:

r685795 | toma | 2007-07-09 21:26:48 +0200 (ma, 09 jul 2007) | 2 lines
Remove the 'Default' statement for the default identity.


That was when I was the maintainer. I've given up on that, so I'm not the one who gets to decide, but if it were up to me, it would not return, cause I don't see any need / advant

- Tom


On 2009-10-22 15:44:37, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1934/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 15:44:37)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> And another small patch to improve the identity combo. This adds the string "(Default)" to the default identity like it is in the KMail user interface to manage the identities.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kpimidentities/identitycombo.cpp 1039027 
> 
> Diff: http://reviewboard.kde.org/r/1934/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/