[Kde-pim] Review Request: Add "(Default)" to the default identity in IdentityCombo

[Ingo Klöcker]

> On 2009-10-23 19:25:11, Tom Albers wrote:
> > I object to this patch. In the settings it makes sense to indicate which identity will be used by default. As in the composer the composer the combo can be hidden and the user would need to know which identity will be used by default.
> > 
> > In the combo it makes no sense to indicate "(Default)". The combo *has* a default value, indicating the default value with "(Default)" makes no sense at all. 
> > 
> > I removed it earlier:
> > 
> > r685795 | toma | 2007-07-09 21:26:48 +0200 (ma, 09 jul 2007) | 2 lines
> > Remove the 'Default' statement for the default identity.
> > 
> > 
> > That was when I was the maintainer. I've given up on that, so I'm not the one who gets to decide, but if it were up to me, it would not return, cause I don't see any need / advant
> 
> Tom Albers wrote:
>     ..age to it.

I have so many identities that the "(Default)" really helps me to see whether I have chosen the correct identity. I'm still using KDE 3.5. Otherwise, I would have probably missed it already in KDE 4.x.

FWIW, I'm pretty sure it's not good usability to present the same thing (i.e. the default identity) in different ways unless there are good reasons (like constraints on the length of the text) to do so. Unless there is a compelling reason not to re-add "(Default)" please reconsider your decision.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1934/#review2789
-----------------------------------------------------------


On 2009-10-22 15:44:37, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1934/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 15:44:37)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> And another small patch to improve the identity combo. This adds the string "(Default)" to the default identity like it is in the KMail user interface to manage the identities.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kpimidentities/identitycombo.cpp 1039027 
> 
> Diff: http://reviewboard.kde.org/r/1934/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/