[Kde-pim] Review Request: Add "(Default)" to the default identity in IdentityCombo

[Martin Gräßlin]

> On 2009-10-22 16:55:36, Thomas McGuire wrote:
> > Generally ok by me, but Tom also has to agree.
> > BTW, this is a bit dangerous for code that relies on currentIdentityName() to return something that the IdentityManager can understand. Same goes for using the QCombobox API here.
> > I think however KMail does not use this, it is a good citizen and uses currentIdentity(). I hope.

currentIdentityName() fetches the string which is returned from the IdentityManager based on the uoid. If it weren't that way I would not have opened this request ;-)

Only dangerous part is so to say that someone uses the QCombobox API directly. I'll try to check with lxr where the IdentityCombo is used.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1934/#review2770
-----------------------------------------------------------


On 2009-10-22 15:44:37, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1934/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 15:44:37)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> And another small patch to improve the identity combo. This adds the string "(Default)" to the default identity like it is in the KMail user interface to manage the identities.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kpimidentities/identitycombo.cpp 1039027 
> 
> Diff: http://reviewboard.kde.org/r/1934/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/