[Kde-pim] Review Request: Port Mailody to KPIMTextEdit

[Tom Albers]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/769/#review1212
-----------------------------------------------------------

Ship it!


Thanks a lot. Looks straightforward to me. If you have tested it, please commit.


trunk/extragear/pim/mailody/src/composer.cpp
<http://reviewboard.kde.org/r/769/#comment762>

    yep. can you add "TODO:" please?


- Tom


On 2009-05-26 14:28:00, Thomas McGuire wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/769/
> -----------------------------------------------------------
> 
> (Updated 2009-05-26 14:28:00)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This makes Mailody use the new text edit class from KPIMTextEdit.
> 
> Advantages:
> - Automatic quote highlighting
> - use isFormatting() to detect if formatting was used, to avoid an unnecessary message box and to avoid sending a HTML part if no HTML is used.
> 
> No other futures of the new text edit are used yet, but this lays the foundation to easily use inline images in the future.
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/pim/mailody/src/CMakeLists.txt 973329 
>   trunk/extragear/pim/mailody/src/composer.cpp 973329 
>   trunk/extragear/pim/mailody/src/composertextedit.h 973329 
>   trunk/extragear/pim/mailody/src/composertextedit.cpp 973329 
> 
> Diff: http://reviewboard.kde.org/r/769/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/