[Kde-pim] Review Request: Port Mailody to KPIMTextEdit

Thomas McGuire mcguire at kde.org
Tue May 26 22:32:49 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/770/
-----------------------------------------------------------

Review request for KDE PIM and Tom Albers.


Summary
-------

(Second attempt, first review request discarded, I couldn't update my diff because of some error.)

This makes Mailody use the new text edit class from KPIMTextEdit.

Advantages:
- Automatic quote highlighting
- use isFormatting() to detect if formatting was used, to avoid an unnecessary message box and to avoid sending a HTML part if no HTML is used.

No other futures of the new text edit are used yet, but this lays the foundation to easily use inline images in the future.


Diffs
-----

  trunk/extragear/pim/mailody/src/composertextedit.cpp 973329 
  trunk/extragear/pim/mailody/src/composer.cpp 973329 
  trunk/extragear/pim/mailody/src/composertextedit.h 973329 
  trunk/extragear/pim/mailody/src/CMakeLists.txt 973329 

Diff: http://reviewboard.kde.org/r/770/diff


Testing
-------


Thanks,

Thomas

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list