[Kde-pim] Review Request: KNode, fix use of KStandardDirs
Michael Leupold
lemma at confuego.org
Thu Mar 26 09:44:25 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/427/
-----------------------------------------------------------
Review request for KDE PIM.
Summary
-------
KNode uses KStandardDirs::locateLocal("data", "knode/") + "otherdir/" in quite some places. This can lead to bugs because the directory is not automatically created. Furthermore "appdata" should be used (which already resolves to the knode apps directory). This patch replies the appearances of + "otherdir/" by KStandardDirs::locateLocal("appdata", "otherdir/").
I've also replaced all other appearances of "data" (includeing KStandardDirs::locateLocal("data", "knode/") -> KStandardDirs::locateLocal("appdata", QString())) where appropriate.
This addresses bug 161595.
https://bugs.kde.org/show_bug.cgi?id=161595
Diffs
-----
/trunk/KDE/kdepim/knode/knode/knarticlefilter.cpp 944639
/trunk/KDE/kdepim/knode/knode/knaccountmanager.cpp 944639
/trunk/KDE/kdepim/knode/knode/knconfig.cpp 944639
/trunk/KDE/kdepim/knode/knode/knconvert.cpp 944639
/trunk/KDE/kdepim/knode/knode/knfiltermanager.cpp 944639
/trunk/KDE/kdepim/knode/knode/knfolder.cpp 944639
/trunk/KDE/kdepim/knode/knode/knfoldermanager.cpp 944639
/trunk/KDE/kdepim/knode/knode/knnntpaccount.cpp 944639
/trunk/KDE/kdepim/knode/knode/settings.cpp 944639
Diff: http://reviewboard.kde.org/r/427/diff
Testing
-------
Thanks,
Michael
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list