[Kde-pim] Review Request: KNode, fix use of KStandardDirs

[Michael Leupold]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/427/
-----------------------------------------------------------

(Updated 2009-03-27 15:05:40.934467)


Review request for KDE PIM.


Changes
-------

You were right, appdata doesn't work if run inside kontact. That's just something I didn't consider. This is the updated patch.


Summary
-------

KNode uses KStandardDirs::locateLocal("data", "knode/") + "otherdir/" in quite some places. This can lead to bugs because the directory is not automatically created. Furthermore "appdata" should be used (which already resolves to the knode apps directory). This patch replies the appearances of + "otherdir/" by KStandardDirs::locateLocal("appdata", "otherdir/").

I've also replaced all other appearances of "data" (includeing KStandardDirs::locateLocal("data", "knode/") -> KStandardDirs::locateLocal("appdata", QString())) where appropriate.


This addresses bug 161595.
    https://bugs.kde.org/show_bug.cgi?id=161595


Diffs (updated)
-----

  /trunk/KDE/kdepim/knode/knaccountmanager.cpp 945063 
  /trunk/KDE/kdepim/knode/knarticlefilter.cpp 945063 
  /trunk/KDE/kdepim/knode/knconfig.cpp 945063 
  /trunk/KDE/kdepim/knode/knconvert.cpp 945063 
  /trunk/KDE/kdepim/knode/knfiltermanager.cpp 945063 
  /trunk/KDE/kdepim/knode/knfolder.cpp 945063 
  /trunk/KDE/kdepim/knode/knfoldermanager.cpp 945063 
  /trunk/KDE/kdepim/knode/knnntpaccount.cpp 945063 

Diff: http://reviewboard.kde.org/r/427/diff


Testing
-------


Thanks,

Michael

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/