[Kde-pim] Review Request: KNode, fix use of KStandardDirs

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/427/#review645
-----------------------------------------------------------


Looks basically ok, but we should check if this also works in Kontact (appdata might return something different there).

- Volker


On 2009-03-26 02:44:25, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/427/
> -----------------------------------------------------------
> 
> (Updated 2009-03-26 02:44:25)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> KNode uses KStandardDirs::locateLocal("data", "knode/") + "otherdir/" in quite some places. This can lead to bugs because the directory is not automatically created. Furthermore "appdata" should be used (which already resolves to the knode apps directory). This patch replies the appearances of + "otherdir/" by KStandardDirs::locateLocal("appdata", "otherdir/").
> 
> I've also replaced all other appearances of "data" (includeing KStandardDirs::locateLocal("data", "knode/") -> KStandardDirs::locateLocal("appdata", QString())) where appropriate.
> 
> 
> This addresses bug 161595.
>     https://bugs.kde.org/show_bug.cgi?id=161595
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/knode/knode/knarticlefilter.cpp 944639 
>   /trunk/KDE/kdepim/knode/knode/knaccountmanager.cpp 944639 
>   /trunk/KDE/kdepim/knode/knode/knconfig.cpp 944639 
>   /trunk/KDE/kdepim/knode/knode/knconvert.cpp 944639 
>   /trunk/KDE/kdepim/knode/knode/knfiltermanager.cpp 944639 
>   /trunk/KDE/kdepim/knode/knode/knfolder.cpp 944639 
>   /trunk/KDE/kdepim/knode/knode/knfoldermanager.cpp 944639 
>   /trunk/KDE/kdepim/knode/knode/knnntpaccount.cpp 944639 
>   /trunk/KDE/kdepim/knode/knode/settings.cpp 944639 
> 
> Diff: http://reviewboard.kde.org/r/427/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/