[Kde-pim] Review Request: KNode, make KIO::Jobs non-interactive, don't let KIO handle authentication

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/431/#review647
-----------------------------------------------------------


KNode does error handling itself, so this should be fine.

- Volker


On 2009-03-26 14:32:19, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/431/
> -----------------------------------------------------------
> 
> (Updated 2009-03-26 14:32:19)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> If you connect to an NNTP server which requires a password and don't enter the password in your config, KIO will prompt you for a username and a password. This is currently not only bugged (no descriptive text) but also gives the user no option to save the password. This bug seems to have sneaked in (maybe on the transition to KDE4?).
> 
> The answer should be to make all KIO::Jobs non-interactive by setting the uiDelegate to 0.
> 
> This patch looks small but it would be nice if someone with KNode experience could review so nothing gets broken (eg. user error reporting). I couldn't find any regressions so far.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/knode/knjobdata.cpp 945063 
> 
> Diff: http://reviewboard.kde.org/r/431/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/