[Kde-pim] Review Request: Add parent, toplevel, index methods to KMime::Content

[Andras Mantia]

> On 2009-06-11 12:28:48, Ingo Klöcker wrote:
> > Looks good except for a few of coding style violations (0L instead of 0; many missing spaces).

Seems my comment got lost...

Thanks for the review. Following the PIM coding style is unfortunately hard for me, after years using a (slightly) different coding style. I try, but I'm sure I will make similar mistakes in the future.

The patch was committed with the changes mentioned by Ingo.


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/826/#review1310
-----------------------------------------------------------


On 2009-06-11 09:26:35, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/826/
> -----------------------------------------------------------
> 
> (Updated 2009-06-11 09:26:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Add some helper methods to KMime::Content to make application writer's life easier. In the mail reader I need to get the index of a Content, but that's possible only if I know the toplevel Content in the mime tree.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kmime/tests/kmime_content_test.h 979973 
>   trunk/KDE/kdepimlibs/kmime/kmime_content_p.h 979973 
>   trunk/KDE/kdepimlibs/kmime/tests/contentindextest.cpp 979973 
>   trunk/KDE/kdepimlibs/kmime/kmime_content.h 979973 
>   trunk/KDE/kdepimlibs/kmime/kmime_content.cpp 979973 
>   trunk/KDE/kdepimlibs/kmime/tests/kmime_content_test.cpp 979973 
> 
> Diff: http://reviewboard.kde.org/r/826/diff
> 
> 
> Testing
> -------
> 
> No real testing yet, only compilation.
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/