[Kde-pim] Review Request: Add parent, toplevel, index methods to KMime::Content
Thomas McGuire
mcguire at kde.org
Thu Jun 11 14:59:17 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/826/#review1300
-----------------------------------------------------------
Ship it!
Looks fine to me, but add an "explicit".
trunk/KDE/kdepimlibs/kmime/kmime_content.h
<http://reviewboard.kde.org/r/826/#comment817>
make it explicit
- Thomas
On 2009-06-11 06:41:26, Andras Mantia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/826/
> -----------------------------------------------------------
>
> (Updated 2009-06-11 06:41:26)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Add some helper methods to KMime::Content to make application writer's life easier. In the mail reader I need to get the index of a Content, but that's possible only if I know the toplevel Content in the mime tree.
>
>
> Diffs
> -----
>
> trunk/KDE/kdepimlibs/kmime/kmime_content.h 979973
> trunk/KDE/kdepimlibs/kmime/kmime_content.cpp 979973
> trunk/KDE/kdepimlibs/kmime/kmime_content_p.h 979973
> trunk/KDE/kdepimlibs/kmime/tests/contentindextest.cpp 979973
> trunk/KDE/kdepimlibs/kmime/tests/kmime_content_test.h 979973
> trunk/KDE/kdepimlibs/kmime/tests/kmime_content_test.cpp 979973
>
> Diff: http://reviewboard.kde.org/r/826/diff
>
>
> Testing
> -------
>
> No real testing yet, only compilation.
>
>
> Thanks,
>
> Andras
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list