[Kde-pim] Review Request: Add parent, toplevel, index methods to KMime::Content

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/826/#review1310
-----------------------------------------------------------


Looks good except for a few of coding style violations (0L instead of 0; many missing spaces).


trunk/KDE/kdepimlibs/kmime/kmime_content.h
<http://reviewboard.kde.org/r/826/#comment831>

    explicit Content( Content *parent )
    (i.e. add missing spaces and move *)
    



trunk/KDE/kdepimlibs/kmime/kmime_content.h
<http://reviewboard.kde.org/r/826/#comment835>

    Please add spaces.



trunk/KDE/kdepimlibs/kmime/kmime_content.cpp
<http://reviewboard.kde.org/r/826/#comment836>

    Please add spaces.



trunk/KDE/kdepimlibs/kmime/kmime_content.cpp
<http://reviewboard.kde.org/r/826/#comment837>

    A space is missing.



trunk/KDE/kdepimlibs/kmime/kmime_content.cpp
<http://reviewboard.kde.org/r/826/#comment838>

    More spaces are missing.



trunk/KDE/kdepimlibs/kmime/kmime_content.cpp
<http://reviewboard.kde.org/r/826/#comment839>

    A null pointer is 0, not 0l, 0L or NULL. (see http://pim.kde.org/development/coding-korganizer.php)



trunk/KDE/kdepimlibs/kmime/kmime_content.cpp
<http://reviewboard.kde.org/r/826/#comment840>

    spaces



trunk/KDE/kdepimlibs/kmime/kmime_content.cpp
<http://reviewboard.kde.org/r/826/#comment832>

    0 instead of 0L



trunk/KDE/kdepimlibs/kmime/kmime_content_p.h
<http://reviewboard.kde.org/r/826/#comment833>

    Please add the initialization of parent to the initialization list of this c'tor. And please drop the 'L' after the '0'.



trunk/KDE/kdepimlibs/kmime/tests/kmime_content_test.cpp
<http://reviewboard.kde.org/r/826/#comment842>

    Lots of missing spaces.



trunk/KDE/kdepimlibs/kmime/tests/kmime_content_test.cpp
<http://reviewboard.kde.org/r/826/#comment841>

    0 instead of 0L



trunk/KDE/kdepimlibs/kmime/tests/kmime_content_test.cpp
<http://reviewboard.kde.org/r/826/#comment834>

    More missing spaces.


- Ingo


On 2009-06-11 09:26:35, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/826/
> -----------------------------------------------------------
> 
> (Updated 2009-06-11 09:26:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Add some helper methods to KMime::Content to make application writer's life easier. In the mail reader I need to get the index of a Content, but that's possible only if I know the toplevel Content in the mime tree.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kmime/tests/kmime_content_test.h 979973 
>   trunk/KDE/kdepimlibs/kmime/kmime_content_p.h 979973 
>   trunk/KDE/kdepimlibs/kmime/tests/contentindextest.cpp 979973 
>   trunk/KDE/kdepimlibs/kmime/kmime_content.h 979973 
>   trunk/KDE/kdepimlibs/kmime/kmime_content.cpp 979973 
>   trunk/KDE/kdepimlibs/kmime/tests/kmime_content_test.cpp 979973 
> 
> Diff: http://reviewboard.kde.org/r/826/diff
> 
> 
> Testing
> -------
> 
> No real testing yet, only compilation.
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/