[Kde-pim] [PATCH] Memory leak in IMAP IOSlave

[Ingo Klöcker]

On Wednesday 25 February 2009, Thomas McGuire wrote:
> Hi,
>
> On Wednesday 25 February 2009 10:47:13 Mike Arthur wrote:
> > On Wednesday 25 February 2009 07:48:55 Thomas McGuire wrote:
> > > Thanks for noticing this and for the patch! I would guess that
> > > this is a Qt4 porting fallout.
> > >
> > > But I'm not particular fond of the way 'delete' is peppered all
> > > over the code now, I think a better solution is to use
> > > boost::shared_ptr in all places where raw imapCommand pointers
> > > are used. This saves the deletes, and we can be sure not to
> > > forget a delete.
> > > Could you change the patch so that boost::shared_ptrs are used
> > > and send that to reviewboard.kde.org (kdepim group)? Best with a
> > > typedef to save typing.
> >
> > If trunk depends on Qt 4.5 now can't you use QSharedPointer?
>
> Right, we can use that now.

But not for the backport to KDE 4.2. So the backport will have to use 
boost::shared_ptr.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090225/aa1fec8c/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/