[Kde-pim] [PATCH] Memory leak in IMAP IOSlave

[Thomas McGuire]

Hi,

On Wednesday 25 February 2009 15:48:38 Tomi Junnila wrote:
> * Mike Arthur <mike at mikearthur.co.uk> wrote on 25.02.09 09:47:
> > On Wednesday 25 February 2009 07:48:55 Thomas McGuire wrote:
> > > But I'm not particular fond of the way 'delete' is peppered all over
> > > the code now, I think a better solution is to use boost::shared_ptr in
> > > all places where raw imapCommand pointers are used. This saves the
> > > deletes, and we can be sure not to forget a delete.
> > > Could you change the patch so that boost::shared_ptrs are used and send
> > > that to reviewboard.kde.org (kdepim group)? Best with a typedef to save
> > > typing.
> >
> > If trunk depends on Qt 4.5 now can't you use QSharedPointer?
>
> I've got minor problems with both Qt 4.5 and boost(::shared_ptr): I don't
> have the former, and have had learning the latter on my to-do list for the
> last couple of years.

I've just fixed this by using boost::shared_ptr. See 
http://websvn.kde.org/?view=rev&revision=932578

Regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090226/ed2e45ce/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/