[Kde-pim] [PATCH] Memory leak in IMAP IOSlave

Tomi Junnila topeju at badzilla.net
Wed Feb 25 14:48:38 GMT 2009


* Mike Arthur <mike at mikearthur.co.uk> wrote on 25.02.09 09:47:
> On Wednesday 25 February 2009 07:48:55 Thomas McGuire wrote:
> > But I'm not particular fond of the way 'delete' is peppered all over the
> > code now, I think a better solution is to use boost::shared_ptr in all
> > places where raw imapCommand pointers are used. This saves the deletes, and
> > we can be sure not to forget a delete.
> > Could you change the patch so that boost::shared_ptrs are used and send
> > that to reviewboard.kde.org (kdepim group)? Best with a typedef to save
> > typing.
> If trunk depends on Qt 4.5 now can't you use QSharedPointer?

I've got minor problems with both Qt 4.5 and boost(::shared_ptr): I don't
have the former, and have had learning the latter on my to-do list for the
last couple of years.


-- 
Tomi Junnila <topeju at badzilla.net>
http://topeju.badzilla.net/
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list