[Kde-pim] Review Request: Addition of "Maintenance" tab to the folder properties dialogue

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/48/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Addition of "Maintenance" tab to the folder properties dialogue.  This displays some information about the folder and index files and the compaction status.  The actions "Rebuild Index" and "Rebuild IMAP Cache" have been moved from the folder popup menu to here.

Added function enableCompaction() to folderstorage.{cpp,h} to allow the folder to be compacted (after user confirmation) if the "compaction unsafe" flag has been set.  There was previously no way to do this apart from editing the kmailrc configuration file.

Removed slotAssignShortcut() from folderview.{cpp,h} - the corresponding action from the main window is used instead.

Moved the "mark_all_as_read" action back to the top of the folder popup menu, as suggested by aseigo.


This addresses bug 115611.
    https://bugs.kde.org/show_bug.cgi?id=115611


Diffs
-----

  /trunk/KDE/kdepim/kmail/folderstorage.h 923792 
  /trunk/KDE/kdepim/kmail/folderstorage.cpp 923792 
  /trunk/KDE/kdepim/kmail/folderview.h 923792 
  /trunk/KDE/kdepim/kmail/folderview.cpp 923792 
  /trunk/KDE/kdepim/kmail/identitydialog.cpp 923792 
  /trunk/KDE/kdepim/kmail/kmfolderdialog.h 923792 
  /trunk/KDE/kdepim/kmail/kmfolderdialog.cpp 923792 
  /trunk/KDE/kdepim/kmail/kmmainwidget.h 923792 
  /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 923792 

Diff: http://reviewboard.kde.org/r/48/diff


Testing
-------

Built KMail from trunk with these patches, checked operation of all functions.


Thanks,

Jonathan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/