[Kde-pim] Review Request: Addition of "Maintenance" tab to the folder properties dialogue

Ingo Klöcker kloecker at kde.org
Wed Feb 11 21:10:29 GMT 2009


On Wednesday 11 February 2009, Thomas McGuire wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/48/#review60
> -----------------------------------------------------------
>
>
> In general, I like the patch very much. Just wanted to say hello so
> that you don't think I forgot about this patch, I'll have time to
> review the patch this weekend in detail.
>
> Just some comments after a quick test:
> - The maintance tab should probably always be last, quota and ACL
> tabs should be before it
> - Compacting for maildir is a no-op, isn't it? If so, the compact
> button shouldn't be shown. 

For maildir the compaction mechanism is "abused" to apply the message 
flags to the filenames. So it's not a no-op. Nevertheless, it probably 
doesn't make sense to show the button for maildir folders.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090211/b724f146/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list