[Kde-pim] Review Request: Addition of "Maintenance" tab to the folder properties dialogue

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/48/#review60
-----------------------------------------------------------


In general, I like the patch very much. Just wanted to say hello so that you don't think I forgot about this patch, I'll have time to review the patch this weekend in detail.

Just some comments after a quick test:
- The maintance tab should probably always be last, quota and ACL tabs should be before it
- Compacting for maildir is a no-op, isn't it? If so, the compact button shouldn't be shown.
- The folder type label in the maintance tab should be prettyfied, e.g. "Disconnected IMAP" instead 
  of DIMAP. Probably can share some code with the "Add Account" button here.
- Having an UI file for the tab would be a bonus, but probably not worth the effort.

Thanks for the patch and please wait for my detailed review during the next days.

- Thomas


On 2009-02-09 06:24:23, Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/48/
> -----------------------------------------------------------
> 
> (Updated 2009-02-09 06:24:23)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Addition of "Maintenance" tab to the folder properties dialogue.  This displays some information about the folder and index files and the compaction status.  The actions "Rebuild Index" and "Rebuild IMAP Cache" have been moved from the folder popup menu to here.
> 
> Added function enableCompaction() to folderstorage.{cpp,h} to allow the folder to be compacted (after user confirmation) if the "compaction unsafe" flag has been set.  There was previously no way to do this apart from editing the kmailrc configuration file.
> 
> Removed slotAssignShortcut() from folderview.{cpp,h} - the corresponding action from the main window is used instead.
> 
> Moved the "mark_all_as_read" action back to the top of the folder popup menu, as suggested by aseigo.
> 
> 
> This addresses bug 115611.
>     https://bugs.kde.org/show_bug.cgi?id=115611
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/folderstorage.h 923792 
>   /trunk/KDE/kdepim/kmail/folderstorage.cpp 923792 
>   /trunk/KDE/kdepim/kmail/folderview.h 923792 
>   /trunk/KDE/kdepim/kmail/folderview.cpp 923792 
>   /trunk/KDE/kdepim/kmail/identitydialog.cpp 923792 
>   /trunk/KDE/kdepim/kmail/kmfolderdialog.h 923792 
>   /trunk/KDE/kdepim/kmail/kmfolderdialog.cpp 923792 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.h 923792 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 923792 
> 
> Diff: http://reviewboard.kde.org/r/48/diff
> 
> 
> Testing
> -------
> 
> Built KMail from trunk with these patches, checked operation of all functions.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/