[Kde-pim] [patch] kmail: fix crashes and null messages

[Jarosław Staniek]

Hello
An attempt to fix possible crashes and "null messages appearing in folders 
like outbox"; for review.

Description:

M    kmail/sievejob.cpp
M    kmail/listjob.cpp
M    kmail/actionscheduler.cpp

* delete this -> deleteLater()

M    kmail/kmfolderindex_sqlite.cpp
M    kmail/kmfolderindex.h

* executes "DELETE FROM messages WHERE id=.." for every for messages
   with 0 serial number, especially for the outbox
* removed commented-out old impl.

M    kmail/kmmessage.h

use K_GLOBAL_STATIC

M    kmail/kmfoldermaildir.cpp

* minor change

M    kmail/jobscheduler.cpp
M    kmail/jobscheduler.h

* ~JobScheduler() use qDeleteAll() (and clear for sanity)

M    kmail/networkaccount.cpp

* use K_GLOBAL_STATIC
* use value() to avoid inserting 0 values
* NetworkAccount::resetConnectionList(): use remove() instead of inserting 0

M    kmail/kmmessage.cpp

* use K_GLOBAL_STATIC
* createForwardBody() simplify the code

M    kmail/kmcommands.cpp

* KMMoveCommand::execute(): skip mesages with serial number == 0
   -this avoids crashes when user tries to clean up a folder with "no subject" 
items

M    kmail/kmmsgbase.cpp

* #ifdef code related to using_mmap when using sqlite mode

M    kmail/networkaccount.h

* use QPointer<KIO::Slave> mSlave and bits for boolean members

M    kmail/kmfoldertree.cpp

* change deleteGroup() call to nonlocalized


-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kmail.patch
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080519/94386661/attachment.ksh>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/