[Kde-pim] [patch] kmail: fix crashes and null messages

[Thomas McGuire]

Hi,

On Monday 19 May 2008, Jarosław Staniek wrote:
> Hello
> An attempt to fix possible crashes and "null messages appearing in folders
> like outbox"; for review.
Seems fine to me, although I didn't test the changes yet.
Just a few small things:

> M    kmail/kmfolderindex.h
>
> * executes "DELETE FROM messages WHERE id=.." for every for messages
>    with 0 serial number, especially for the outbox
> * removed commented-out old impl.
I didn't review this

> * use K_GLOBAL_STATIC
> * use value() to avoid inserting 0 values
> * NetworkAccount::resetConnectionList(): use remove() instead of inserting
>   0
Any special reason you changed this from QMap to QHash?

Regards,
Thomas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080520/5c4c0211/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/