[Kde-pim] For review: Better support of rich text summary/location

Thomas Thrainer tom_t at gmx.at
Thu Jun 12 07:22:48 BST 2008


Hi there!

> - The existing API is frozen, so I don't think we can change the default
>   values for isRich in setSummary(), setDescription() and setLocation().
>   maybe you can create some new methods that do things the new way
>   and KDE_DEPRECATE the current ones?  unfortunately, I don't think
>   we can overload the new way because the signatures will be the same.
I spend 2 days thinking about this, but don't come to a conclusion. So I 
thought I'm better off asking ;-)

Why would it change the API if I replace one method with 2 parameters, the 
latter has a default value, with 2 methods with the same name, one taking one 
parameter and the other taking 2 parameters? I mean, it's still possible to 
call setX() with one or two parameters.

According to 
http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B 
these changes would even be binary compatible, altough programs would have to 
be recompiled in order to use the new 1-parameter setX() methods. Not 
recompiled programs would just call the 2-parameter setX() with false as 
second parameter.

OTOH however, this change would change the behaviour of the setX() methods 
slightly. But I also changed the bahaviour of IncidenceBase::dtStartStr() and 
Event::dtEndStr() (as they now return no time in the string when the 
incidence is all day), but this seems to be ok.

So, am I missing something? I am quite new to KDE and library progamming in 
general, so I'd like to learn some more if I'm wrong with this.

Thanks,
Thomas
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list