[Kde-pim] [patch] Printing emails [version 2]

[Thomas McGuire]

Hi Jaroslaw,

On Wednesday 09 July 2008 01:30:43 Jaroslaw Staniek wrote:
> Thomas McGuire said the following, On 2008-07-08 18:43:
> > Please go for a signal/slot solution.
>
> Attached for review.
Thanks, this patch seems OK, please commit (with the comment below taken into 
account).

But could you please document the gotchas in the code? There are quite a bit 
of surprising things there, it would be easier to understand with comments:
- when calling new KMReaderWin, add a comment where it is deleted
- add a comment to the API docs of printMsg() that the function deletes the 
  object when it is finished, which is not normal member function behavior
- in the header file, add a comment to mPartHtmlWriter, so we can directly 
  understand that this is only a reference to the writer, so that we can 
  connect to its signal

Regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080709/cad4e3fe/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/