[Kde-pim] [patch] vcard parser bugfix

Martin Koller m.koller at surfeu.at
Sat Dec 27 22:47:37 GMT 2008


Hi all,

working on the kdepim-sync opensync plugin, I found that the vcard 
parsing in KDE is still broken w.r.t. time parsing of the ISO-8601 
spec. ( http://en.wikipedia.org/wiki/ISO_8601#Times ) as it does not 
respect the possibility of the basic format (without the ":" delimiter) 
and the possibility to only have the minutes and seconds optional.

The attached patch tries to fix that, but I could not test it up till 
now as I first wanted to make a standard test for it, but I stumble 
over the tests as they are implemented now.

Can someone tell me how the current tests located in 
kdepimlibs/kabc/vcardparser/tests can be run ?

Still, I already attach the patch here.

Another question I have is regarding KDE4 and PIM itself:
I'm still running KDE3 and the opensync-plugin I fixed now is still 
using all KDE3 libs (kabc, libkcal).
Is this supposed to stay in KDE4(.2) this way, or will the libs go away 
in favor of akonadi ?
So does it make any sense to make the opensync kdepim plugin also run 
for KDE4 with the current implementation/libs ?

-- 
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail 
          /\                        - against microsoft attachments
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parseDT.patch
Type: text/x-diff
Size: 3002 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20081227/b96dd301/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20081227/b96dd301/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list